From 78bc93cc9e68392b3a9e10fcb196c01fe9da42c4 Mon Sep 17 00:00:00 2001
From: Ofer Mendelevitch <ofermend@gmail.com>
Date: Sun, 31 Dec 2023 18:59:49 -0800
Subject: [PATCH] bug fix

---
 .../components/nodes/chains/VectaraChain/VectaraChain.ts  | 8 +++++---
 packages/components/nodes/vectorstores/Vectara/Vectara.ts | 6 +++---
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/packages/components/nodes/chains/VectaraChain/VectaraChain.ts b/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
index c80b354f7..16257b69d 100644
--- a/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
+++ b/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
@@ -249,18 +249,20 @@ class VectaraChain_Chains implements INode {
         }))
 
         const mmrRerankerId = 272725718 // Vectara reranker ID for MMR
+        const mmrEnabled = vectaraFilter?.mmrConfig?.mmrDiversityBias > 0
+
         const data = {
             query: [
                 {
                     query: input,
                     start: 0,
-                    numResults: vectaraFilter?.mmrConfig?.mmrK > 0 ? vectaraFilter?.mmrK : topK,
+                    numResults: mmrEnabled ? vectaraFilter?.mmrK : topK,
                     corpusKey: corpusKeys,
                     contextConfig: {
                         sentencesAfter: vectaraFilter?.contextConfig?.sentencesAfter ?? 2,
                         sentencesBefore: vectaraFilter?.contextConfig?.sentencesBefore ?? 2
                     },
-                    ...(vectaraFilter?.mmrConfig?.mmrK > 0
+                    ...(mmrEnabled
                         ? {
                               rerankingConfig: {
                                   rerankerId: mmrRerankerId,
@@ -299,7 +301,7 @@ class VectaraChain_Chains implements INode {
 
             // remove responses that are not in the topK (in case of MMR)
             // Note that this does not really matter functionally due to the reorder citations, but it is more efficient
-            const maxResponses = vectaraFilter?.mmrConfig?.mmrK > 0 ? Math.min(responses.length, topK) : responses.length
+            const maxResponses = mmrEnabled ? Math.min(responses.length, topK) : responses.length
             if (responses.length > maxResponses) {
                 responses.splice(0, maxResponses)
             }
diff --git a/packages/components/nodes/vectorstores/Vectara/Vectara.ts b/packages/components/nodes/vectorstores/Vectara/Vectara.ts
index 98acf00c2..488a88036 100644
--- a/packages/components/nodes/vectorstores/Vectara/Vectara.ts
+++ b/packages/components/nodes/vectorstores/Vectara/Vectara.ts
@@ -110,8 +110,8 @@ class Vectara_VectorStores implements INode {
             {
                 label: 'MMR diversity bias',
                 name: 'mmrDiversityBias',
-                description: 'The diversity bias to use for MMR. Defaults to 0.3',
-                placeholder: '0.3',
+                description: 'The diversity bias to use for MMR. Defaults to 0 (MMR disabled)',
+                placeholder: '0.0',
                 type: 'number',
                 additionalParams: true,
                 optional: true
@@ -230,7 +230,7 @@ class Vectara_VectorStores implements INode {
         if (sentencesBefore) vectaraContextConfig.sentencesBefore = sentencesBefore
         if (sentencesAfter) vectaraContextConfig.sentencesAfter = sentencesAfter
         vectaraFilter.contextConfig = vectaraContextConfig
-        if (mmrK) vectaraFilter.mmrConfig = { mmrK: mmrK, diversityBias: mmrDiversityBias }
+        vectaraFilter.mmrConfig = { mmrK: mmrK, diversityBias: mmrDiversityBias }
 
         const vectorStore = new VectaraStore(vectaraArgs)