From b44a0f1d39f5c7f3c1c00a16900229fb6a3b7e08 Mon Sep 17 00:00:00 2001
From: Ofer Mendelevitch <ofermend@gmail.com>
Date: Sun, 31 Dec 2023 21:53:48 -0800
Subject: [PATCH] bugfix

---
 .../nodes/chains/VectaraChain/VectaraChain.ts      |  4 ++--
 .../nodes/vectorstores/Vectara/Vectara.ts          | 14 ++++----------
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/packages/components/nodes/chains/VectaraChain/VectaraChain.ts b/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
index 16257b69d..986d587aa 100644
--- a/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
+++ b/packages/components/nodes/chains/VectaraChain/VectaraChain.ts
@@ -249,14 +249,14 @@ class VectaraChain_Chains implements INode {
         }))
 
         const mmrRerankerId = 272725718 // Vectara reranker ID for MMR
-        const mmrEnabled = vectaraFilter?.mmrConfig?.mmrDiversityBias > 0
+        const mmrEnabled = vectaraFilter?.mmrConfig?.enabled
 
         const data = {
             query: [
                 {
                     query: input,
                     start: 0,
-                    numResults: mmrEnabled ? vectaraFilter?.mmrK : topK,
+                    numResults: mmrEnabled ? vectaraFilter?.mmrTopK : topK,
                     corpusKey: corpusKeys,
                     contextConfig: {
                         sentencesAfter: vectaraFilter?.contextConfig?.sentencesAfter ?? 2,
diff --git a/packages/components/nodes/vectorstores/Vectara/Vectara.ts b/packages/components/nodes/vectorstores/Vectara/Vectara.ts
index d83f6cb9e..be63d5822 100644
--- a/packages/components/nodes/vectorstores/Vectara/Vectara.ts
+++ b/packages/components/nodes/vectorstores/Vectara/Vectara.ts
@@ -1,12 +1,5 @@
 import { flatten } from 'lodash'
-import {
-    VectaraStore,
-    VectaraLibArgs,
-    VectaraFilter,
-    VectaraContextConfig,
-    VectaraFile,
-    VectaraMMRConfig
-} from 'langchain/vectorstores/vectara'
+import { VectaraStore, VectaraLibArgs, VectaraFilter, VectaraContextConfig, VectaraFile, MMRConfig } from 'langchain/vectorstores/vectara'
 import { Document } from 'langchain/document'
 import { Embeddings } from 'langchain/embeddings/base'
 import { ICommonObject, INode, INodeData, INodeOutputsValue, INodeParams } from '../../../src/Interface'
@@ -237,8 +230,9 @@ class Vectara_VectorStores implements INode {
         if (sentencesBefore) vectaraContextConfig.sentencesBefore = sentencesBefore
         if (sentencesAfter) vectaraContextConfig.sentencesAfter = sentencesAfter
         vectaraFilter.contextConfig = vectaraContextConfig
-        const mmrConfig: VectaraMMRConfig = {}
-        mmrConfig.mmrK = mmrK
+        const mmrConfig: MMRConfig = {}
+        mmrConfig.enabled = mmrDiversityBias > 0
+        mmrConfig.mmrTopK = mmrK
         mmrConfig.diversityBias = mmrDiversityBias
         vectaraFilter.mmrConfig = mmrConfig