fix: OpenAI Assistant tool call failures masked as success (#5504)
Fix OpenAI Assistant tool error analytics
This commit is contained in:
parent
ffe69936dc
commit
ca22160361
|
|
@ -578,7 +578,7 @@ class OpenAIAssistant_Agents implements INode {
|
||||||
toolOutput
|
toolOutput
|
||||||
})
|
})
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
await analyticHandlers.onToolEnd(toolIds, e)
|
await analyticHandlers.onToolError(toolIds, e)
|
||||||
console.error('Error executing tool', e)
|
console.error('Error executing tool', e)
|
||||||
throw new Error(
|
throw new Error(
|
||||||
`Error executing tool. Tool: ${tool.name}. Thread ID: ${threadId}. Run ID: ${runThreadId}`
|
`Error executing tool. Tool: ${tool.name}. Thread ID: ${threadId}. Run ID: ${runThreadId}`
|
||||||
|
|
@ -703,7 +703,7 @@ class OpenAIAssistant_Agents implements INode {
|
||||||
toolOutput
|
toolOutput
|
||||||
})
|
})
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
await analyticHandlers.onToolEnd(toolIds, e)
|
await analyticHandlers.onToolError(toolIds, e)
|
||||||
console.error('Error executing tool', e)
|
console.error('Error executing tool', e)
|
||||||
clearInterval(timeout)
|
clearInterval(timeout)
|
||||||
reject(
|
reject(
|
||||||
|
|
@ -1096,7 +1096,7 @@ async function handleToolSubmission(params: ToolSubmissionParams): Promise<ToolS
|
||||||
toolOutput
|
toolOutput
|
||||||
})
|
})
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
await analyticHandlers.onToolEnd(toolIds, e)
|
await analyticHandlers.onToolError(toolIds, e)
|
||||||
console.error('Error executing tool', e)
|
console.error('Error executing tool', e)
|
||||||
throw new Error(`Error executing tool. Tool: ${tool.name}. Thread ID: ${threadId}. Run ID: ${runThreadId}`)
|
throw new Error(`Error executing tool. Tool: ${tool.name}. Thread ID: ${threadId}. Run ID: ${runThreadId}`)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue