From e99aecb473140776a6941c9b9da61135649e1569 Mon Sep 17 00:00:00 2001 From: Henry Heng Date: Thu, 14 Aug 2025 15:52:53 +0800 Subject: [PATCH] Chore/remove redundant loggers (#5067) remove redundant loggers --- packages/server/src/queue/BaseQueue.ts | 10 ------- packages/server/src/queue/PredictionQueue.ts | 7 ----- packages/server/src/queue/QueueManager.ts | 27 ------------------- .../server/src/queue/RedisEventPublisher.ts | 13 --------- .../server/src/queue/RedisEventSubscriber.ts | 13 --------- 5 files changed, 70 deletions(-) diff --git a/packages/server/src/queue/BaseQueue.ts b/packages/server/src/queue/BaseQueue.ts index 49e634535..87b3a9fae 100644 --- a/packages/server/src/queue/BaseQueue.ts +++ b/packages/server/src/queue/BaseQueue.ts @@ -57,8 +57,6 @@ export abstract class BaseQueue { } public createWorker(concurrency: number = WORKER_CONCURRENCY): Worker { - logger.info(`[BaseQueue] Creating worker for queue "${this.queue.name}" with concurrency: ${concurrency}`) - try { this.worker = new Worker( this.queue.name, @@ -92,14 +90,6 @@ export abstract class BaseQueue { logger.error(`[BaseQueue] Worker error for queue "${this.queue.name}":`, { error: err }) }) - this.worker.on('ready', () => { - logger.info(`[BaseQueue] Worker ready for queue "${this.queue.name}"`) - }) - - this.worker.on('closing', () => { - logger.info(`[BaseQueue] Worker closing for queue "${this.queue.name}"`) - }) - this.worker.on('closed', () => { logger.info(`[BaseQueue] Worker closed for queue "${this.queue.name}"`) }) diff --git a/packages/server/src/queue/PredictionQueue.ts b/packages/server/src/queue/PredictionQueue.ts index af0c9d8c7..10cc125f7 100644 --- a/packages/server/src/queue/PredictionQueue.ts +++ b/packages/server/src/queue/PredictionQueue.ts @@ -100,13 +100,6 @@ export class PredictionQueue extends BaseQueue { data.signal = signal } - if (this.redisPublisher) { - logger.info( - `[PredictionQueue] RedisPublisher is connected [orgId:${data.orgId}/flowId:${data.chatflow.id}/chatId:${data.chatId}]`, - this.redisPublisher.isConnected() - ) - } - return await executeFlow(data) } } diff --git a/packages/server/src/queue/QueueManager.ts b/packages/server/src/queue/QueueManager.ts index 7a17cfd16..eef90b33b 100644 --- a/packages/server/src/queue/QueueManager.ts +++ b/packages/server/src/queue/QueueManager.ts @@ -12,7 +12,6 @@ import { BullMQAdapter } from '@bull-board/api/bullMQAdapter' import { Express } from 'express' import { UsageCacheManager } from '../UsageCacheManager' import { ExpressAdapter } from '@bull-board/express' -import logger from '../utils/logger' const QUEUE_NAME = process.env.QUEUE_NAME || 'flowise-queue' @@ -48,9 +47,6 @@ export class QueueManager { ? parseInt(process.env.REDIS_KEEP_ALIVE, 10) : undefined } - logger.info( - `[QueueManager] Connecting to Redis using URL: ${process.env.REDIS_URL.replace(/\/\/[^:]+:[^@]+@/, '//[CREDENTIALS]@')}` - ) } else { let tlsOpts = undefined if (process.env.REDIS_TLS === 'true') { @@ -72,11 +68,6 @@ export class QueueManager { ? parseInt(process.env.REDIS_KEEP_ALIVE, 10) : undefined } - logger.info( - `[QueueManager] Connecting to Redis using host:port: ${process.env.REDIS_HOST || 'localhost'}:${ - process.env.REDIS_PORT || '6379' - }` - ) } } @@ -149,15 +140,6 @@ export class QueueManager { }) this.registerQueue('prediction', predictionQueue) - // Add connection event logging for prediction queue - if (predictionQueue.getQueue().opts.connection) { - const connInfo = predictionQueue.getQueue().opts.connection || {} - const connInfoString = JSON.stringify(connInfo) - .replace(/"username":"[^"]*"/g, '"username":"[REDACTED]"') - .replace(/"password":"[^"]*"/g, '"password":"[REDACTED]"') - logger.info(`[QueueManager] Prediction queue connected to Redis: ${connInfoString}`) - } - this.predictionQueueEventsProducer = new QueueEventsProducer(predictionQueue.getQueueName(), { connection: this.connection }) @@ -172,15 +154,6 @@ export class QueueManager { }) this.registerQueue('upsert', upsertionQueue) - // Add connection event logging for upsert queue - if (upsertionQueue.getQueue().opts.connection) { - const connInfo = upsertionQueue.getQueue().opts.connection || {} - const connInfoString = JSON.stringify(connInfo) - .replace(/"username":"[^"]*"/g, '"username":"[REDACTED]"') - .replace(/"password":"[^"]*"/g, '"password":"[REDACTED]"') - logger.info(`[QueueManager] Upsert queue connected to Redis: ${connInfoString}`) - } - if (serverAdapter) { createBullBoard({ queues: [new BullMQAdapter(predictionQueue.getQueue()), new BullMQAdapter(upsertionQueue.getQueue())], diff --git a/packages/server/src/queue/RedisEventPublisher.ts b/packages/server/src/queue/RedisEventPublisher.ts index f2b601508..55b513b52 100644 --- a/packages/server/src/queue/RedisEventPublisher.ts +++ b/packages/server/src/queue/RedisEventPublisher.ts @@ -77,20 +77,7 @@ export class RedisEventPublisher implements IServerSideEventStreamer { } async connect() { - logger.info(`[RedisEventPublisher] Connecting to Redis...`) await this.redisPublisher.connect() - - // Log connection details after successful connection - const connInfo = this.redisPublisher.options?.socket - const connInfoString = JSON.stringify(connInfo) - .replace(/"username":"[^"]*"/g, '"username":"[REDACTED]"') - .replace(/"password":"[^"]*"/g, '"password":"[REDACTED]"') - logger.info(`[RedisEventPublisher] Connected to Redis: ${connInfoString}`) - - // Add error event listener - this.redisPublisher.on('error', (err) => { - logger.error(`[RedisEventPublisher] Redis connection error`, { error: err }) - }) } streamCustomEvent(chatId: string, eventType: string, data: any) { diff --git a/packages/server/src/queue/RedisEventSubscriber.ts b/packages/server/src/queue/RedisEventSubscriber.ts index a202bdc65..f9069264b 100644 --- a/packages/server/src/queue/RedisEventSubscriber.ts +++ b/packages/server/src/queue/RedisEventSubscriber.ts @@ -77,20 +77,7 @@ export class RedisEventSubscriber { } async connect() { - logger.info(`[RedisEventSubscriber] Connecting to Redis...`) await this.redisSubscriber.connect() - - // Log connection details after successful connection - const connInfo = this.redisSubscriber.options?.socket - const connInfoString = JSON.stringify(connInfo) - .replace(/"username":"[^"]*"/g, '"username":"[REDACTED]"') - .replace(/"password":"[^"]*"/g, '"password":"[REDACTED]"') - logger.info(`[RedisEventSubscriber] Connected to Redis: ${connInfoString}`) - - // Add error event listener - this.redisSubscriber.on('error', (err) => { - logger.error(`[RedisEventSubscriber] Redis connection error`, { error: err }) - }) } subscribe(channel: string) {