From 044e33c5d54f438d56594e7bdb80758873b616c5 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Wed, 26 Aug 2020 17:39:41 +0300 Subject: [PATCH] Review use of fontWeight --- lib/ui/app/FieldGrid.dart | 1 - lib/ui/auth/login_view.dart | 1 - lib/ui/dashboard/dashboard_chart.dart | 5 ++--- lib/ui/settings/templates_and_reminders.dart | 8 ++++---- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/ui/app/FieldGrid.dart b/lib/ui/app/FieldGrid.dart index d9d569100..5c6b59695 100644 --- a/lib/ui/app/FieldGrid.dart +++ b/lib/ui/app/FieldGrid.dart @@ -23,7 +23,6 @@ class FieldGrid extends StatelessWidget { localization.lookup(field), overflow: TextOverflow.ellipsis, style: TextStyle( - fontWeight: FontWeight.w300, color: textColor.withOpacity(.65), ), ), diff --git a/lib/ui/auth/login_view.dart b/lib/ui/auth/login_view.dart index 583ec4ca3..9bd92b954 100644 --- a/lib/ui/auth/login_view.dart +++ b/lib/ui/auth/login_view.dart @@ -575,7 +575,6 @@ class _LoginState extends State { _loginError, style: TextStyle( color: Colors.red, - fontWeight: FontWeight.bold, ), ), ), diff --git a/lib/ui/dashboard/dashboard_chart.dart b/lib/ui/dashboard/dashboard_chart.dart index 89fa2a32e..84ca904b9 100644 --- a/lib/ui/dashboard/dashboard_chart.dart +++ b/lib/ui/dashboard/dashboard_chart.dart @@ -164,8 +164,8 @@ class _DashboardChartState extends State { children: [ Text(localization.lookup(dataGroup.name), style: theme.textTheme.headline5.copyWith( - color: isSelected ? Colors.white : null, - fontWeight: FontWeight.w400)), + color: isSelected ? Colors.white : null, + )), SizedBox(height: 4.0), Text( formatNumber(dataGroup.total, context, @@ -183,7 +183,6 @@ class _DashboardChartState extends State { : (isIncrease ? Colors.green : Colors.red), - fontWeight: FontWeight.bold, ), ) : SizedBox(), diff --git a/lib/ui/settings/templates_and_reminders.dart b/lib/ui/settings/templates_and_reminders.dart index 87f4f63a0..de08ab227 100644 --- a/lib/ui/settings/templates_and_reminders.dart +++ b/lib/ui/settings/templates_and_reminders.dart @@ -548,10 +548,10 @@ class EmailPreview extends StatelessWidget { padding: const EdgeInsets.all(14), child: Text( subject, - style: Theme.of(context).textTheme.bodyText1.copyWith( - color: Colors.black, - fontWeight: FontWeight.w700, - ), + style: Theme.of(context) + .textTheme + .bodyText1 + .copyWith(color: Colors.black), ), ), Expanded(