From 1b3415bda8f967432641390d3b5dd7f4e3a20f30 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Sat, 11 Feb 2023 20:04:40 +0200 Subject: [PATCH] Tax Report calculating incorrectly when discount is applied #554 --- lib/data/models/mixins/invoice_mixin.dart | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/lib/data/models/mixins/invoice_mixin.dart b/lib/data/models/mixins/invoice_mixin.dart index 2d8e9ccc7..d0db8da4c 100644 --- a/lib/data/models/mixins/invoice_mixin.dart +++ b/lib/data/models/mixins/invoice_mixin.dart @@ -143,16 +143,6 @@ abstract class CalculateInvoiceTotal { lineItems.forEach((invoiceItem) { double lineTotal = invoiceItem.quantity * invoiceItem.cost; - if (discount != 0) { - if (isAmountDiscount) { - if (total != 0) { - lineTotal -= round(lineTotal / total * discount, precision); - } - } else { - lineTotal -= round(lineTotal * discount / 100, precision); - } - } - if (invoiceItem.discount != 0) { if (isAmountDiscount) { lineTotal -= invoiceItem.discount; @@ -164,7 +154,7 @@ abstract class CalculateInvoiceTotal { total += lineTotal; }); - if (discount > 0) { + if (discount != 0) { if (isAmountDiscount) { total -= discount; } else {