Code refactor

lib/redux/app/app_middleware.dart

@@ -419,12 +419,14 @@ Middleware<AppState> _createAccountLoaded() {
     final action = dynamicAction as LoadAccountSuccess;
     final response = action.loginResponse;
     final selectedCompanyIndex = store.state.uiState.selectedCompanyIndex;
+    final loadedStaticData = response.static.currencies.isNotEmpty;
 
-    if (response.static.currencies.isNotEmpty) {
+    if (loadedStaticData) {
       store.dispatch(LoadStaticSuccess(data: response.static));
     }
 
     print('## userCompanies.length: ${response.userCompanies.length}');
+
     for (int i = 0; i < response.userCompanies.length; i++) {
       final UserCompanyEntity userCompany = response.userCompanies[i];
 
@@ -433,11 +435,11 @@ Middleware<AppState> _createAccountLoaded() {
         prefs.setString(kSharedPrefToken, userCompany.token.obscuredToken);
       }
 
-      store.dispatch(SelectCompany(i));
+      store.dispatch(SelectCompany(companyIndex: i, clearSelection: loadedStaticData));
       store.dispatch(LoadCompanySuccess(userCompany));
     }
 
-    store.dispatch(SelectCompany(selectedCompanyIndex));
+    store.dispatch(SelectCompany(companyIndex: selectedCompanyIndex, clearSelection: loadedStaticData));
     store.dispatch(UserLoginSuccess());
 
     print('## Account is loaded');

lib/redux/auth/auth_middleware.dart

@@ -270,7 +270,7 @@ Middleware<AppState> _createCompany(AuthRepository repository) {
       store.dispatch(RefreshData(
         completer: Completer<Null>()
           ..future.then<Null>((_) {
-            store.dispatch(SelectCompany(state.companies.length));
+            store.dispatch(SelectCompany(companyIndex: state.companies.length));
             store.dispatch(ViewDashboard(
                 navigator: Navigator.of(action.context), force: true));
           }),

lib/redux/client/client_reducer.dart

@@ -49,7 +49,8 @@ final selectedIdReducer = combineReducers<String>([
   TypedReducer<String, AddClientSuccess>((selectedId, action) {
     return action.client.id;
   }),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>(
+      (selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteClientsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveClientsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/company/company_actions.dart

@@ -6,9 +6,13 @@ import 'package:invoiceninja_flutter/data/models/company_model.dart';
 import 'package:invoiceninja_flutter/redux/app/app_actions.dart';
 
 class SelectCompany {
-  SelectCompany(this.companyIndex);
+  SelectCompany({
+    @required this.companyIndex,
+    this.clearSelection = true,
+  });
 
   final int companyIndex;
+  final bool clearSelection;
 }
 
 class LoadCompanySuccess {
@@ -44,6 +48,7 @@ class SaveCompanyFailure implements StopSaving {
 
 class AddCompany implements StartSaving {
   AddCompany(this.context);
+
   final BuildContext context;
 }
 

lib/redux/company_gateway/company_gateway_reducer.dart

@@ -21,7 +21,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, action) => action.companyGatewayId),
   TypedReducer<String, AddCompanyGatewaySuccess>(
       (String selectedId, action) => action.companyGateway.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteCompanyGatewaySuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveCompanyGatewaySuccess>(
       (selectedId, action) => ''),

lib/redux/credit/credit_reducer.dart

@@ -37,7 +37,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (selectedId, action) => action.credit.id),
   TypedReducer<String, ShowEmailCredit>(
       (selectedId, action) => action.credit.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteCreditsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveCreditsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/design/design_reducer.dart

@@ -20,7 +20,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, dynamic action) => action.designId),
   TypedReducer<String, AddDesignSuccess>(
       (String selectedId, dynamic action) => action.design.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteDesignsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveDesignsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/document/document_reducer.dart

@@ -18,7 +18,7 @@ EntityUIState documentUIReducer(DocumentUIState state, dynamic action) {
 Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewDocument>((selectedId, action) => action.documentId),
   //TypedReducer<String, AddDocumentSuccess>((selectedId, action) => action.document.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteDocumentSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveDocumentSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/expense/expense_reducer.dart

@@ -19,7 +19,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewExpense>((selectedId, action) => action.expenseId),
   TypedReducer<String, AddExpenseSuccess>(
       (selectedId, action) => action.expense.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteExpenseSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveExpenseSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/group/group_reducer.dart

@@ -21,7 +21,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, action) => action.groupId),
   TypedReducer<String, AddGroupSuccess>(
       (String selectedId, action) => action.group.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteGroupSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveGroupSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/invoice/invoice_reducer.dart

@@ -39,7 +39,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (selectedId, action) => action.invoice.id),
   TypedReducer<String, ShowEmailInvoice>(
       (selectedId, action) => action.invoice.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteInvoicesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveInvoicesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/payment/payment_reducer.dart

@@ -19,7 +19,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewPayment>((selectedId, action) => action.paymentId),
   TypedReducer<String, AddPaymentSuccess>(
       (selectedId, action) => action.payment.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeletePaymentsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchivePaymentsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/payment_term/payment_term_reducer.dart

@@ -20,7 +20,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, dynamic action) => action.paymentTermId),
   TypedReducer<String, AddPaymentTermSuccess>(
       (String selectedId, dynamic action) => action.paymentTerm.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeletePaymentTermsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchivePaymentTermsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/product/product_reducer.dart

@@ -56,7 +56,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewProduct>((selectedId, action) => action.productId),
   TypedReducer<String, AddProductSuccess>(
       (selectedId, action) => action.product.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteProductsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveProductsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/project/project_reducer.dart

@@ -35,7 +35,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewProject>((selectedId, action) => action.projectId),
   TypedReducer<String, AddProjectSuccess>(
       (selectedId, action) => action.project.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteProjectSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveProjectSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/quote/quote_reducer.dart

@@ -37,7 +37,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, AddQuoteSuccess>(
       (selectedId, action) => action.quote.id),
   TypedReducer<String, ShowEmailQuote>((selectedId, action) => action.quote.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteQuotesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveQuotesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/task/task_reducer.dart

@@ -28,7 +28,7 @@ TaskTime editTaskTime(TaskTime taskTime, dynamic action) {
 Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewTask>((selectedId, action) => action.taskId),
   TypedReducer<String, AddTaskSuccess>((selectedId, action) => action.task.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteTaskSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveTaskSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/tax_rate/tax_rate_reducer.dart

@@ -20,7 +20,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, action) => action.taxRateId),
   TypedReducer<String, AddTaxRateSuccess>(
       (String selectedId, action) => action.taxRate.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteTaxRatesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveTaxRatesSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/token/token_reducer.dart

@@ -21,7 +21,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, dynamic action) => action.tokenId),
   TypedReducer<String, AddTokenSuccess>(
       (String selectedId, dynamic action) => action.token.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteTokensSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveTokensSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/user/user_reducer.dart

@@ -19,7 +19,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewUser>((String selectedId, action) => action.userId),
   TypedReducer<String, AddUserSuccess>(
       (String selectedId, action) => action.user.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteUserSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveUserSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/vendor/vendor_reducer.dart

@@ -47,7 +47,7 @@ Reducer<String> selectedIdReducer = combineReducers([
   TypedReducer<String, ViewVendor>((selectedId, action) => action.vendorId),
   TypedReducer<String, AddVendorSuccess>(
       (selectedId, action) => action.vendor.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteVendorSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveVendorSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/redux/webhook/webhook_reducer.dart

@@ -21,7 +21,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, dynamic action) => action.webhookId),
   TypedReducer<String, AddWebhookSuccess>(
       (String selectedId, dynamic action) => action.webhook.id),
-  TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+  TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
   TypedReducer<String, DeleteWebhooksSuccess>((selectedId, action) => ''),
   TypedReducer<String, ArchiveWebhooksSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),

lib/ui/app/menu_drawer_vm.dart

@@ -60,7 +60,7 @@ class MenuDrawerVM {
       onCompanyChanged:
           (BuildContext context, String companyIndex, CompanyEntity company) {
         store.dispatch(ClearEntityFilter());
-        store.dispatch(SelectCompany(int.parse(companyIndex)));
+        store.dispatch(SelectCompany(companyIndex: int.parse(companyIndex)));
         if (store.state.isStale) {
           if (!store.state.isLoaded && store.state.company.isLarge) {
             store.dispatch(LoadClients());

lib/ui/settings/account_management_vm.dart

@@ -66,7 +66,7 @@ class AccountManagementVM {
                     break;
                   }
                 }
-                store.dispatch(SelectCompany(index));
+                store.dispatch(SelectCompany(companyIndex: index));
                 store.dispatch(ViewDashboard(navigator: Navigator.of(context)));
               } else {
                 store.dispatch(UserLogout(context));

stubs/redux/stub/stub_reducer

@@ -21,7 +21,7 @@ Reducer<String> selectedIdReducer = combineReducers([
       (String selectedId, dynamic action) => action.stubId),
   TypedReducer<String, AddStubSuccess>(
       (String selectedId, dynamic action) => action.stub.id),
-    TypedReducer<String, SelectCompany>((selectedId, action) => ''),
+    TypedReducer<String, SelectCompany>((selectedId, action) => action.clearSelection ? '' : selectedId),
       TypedReducer<String, DeleteStubsSuccess>((selectedId, action) => ''),
       TypedReducer<String, ArchiveStubsSuccess>((selectedId, action) => ''),
   TypedReducer<String, ClearEntityFilter>((selectedId, action) => ''),