From 712dfa645a86a3ea7936e0550601768e44533110 Mon Sep 17 00:00:00 2001
From: Hillel Coren <hillelcoren@gmail.com>
Date: Fri, 3 Nov 2023 12:21:58 +0200
Subject: [PATCH] Apply check response to raw responses

---
 lib/data/web_client.dart        |  8 ++++----
 lib/ui/client/client_pdf.dart   | 13 -------------
 lib/ui/invoice/invoice_pdf.dart | 13 -------------
 lib/utils/designs.dart          |  8 +-------
 4 files changed, 5 insertions(+), 37 deletions(-)

diff --git a/lib/data/web_client.dart b/lib/data/web_client.dart
index 67f728483..56a6f2e8b 100644
--- a/lib/data/web_client.dart
+++ b/lib/data/web_client.dart
@@ -51,12 +51,12 @@ class WebClient {
     );
     client.close();
 
+    _checkResponse(url, response);
+
     if (rawResponse) {
       return response;
     }
 
-    _checkResponse(url, response);
-
     final dynamic jsonResponse = json.decode(response.body);
 
     //debugPrint(response.body, wrapWidth: 1000);
@@ -113,12 +113,12 @@ class WebClient {
       client.close();
     }
 
+    _checkResponse(url, response);
+
     if (rawResponse) {
       return response;
     }
 
-    _checkResponse(url, response);
-
     return json.decode(response.body);
   }
 
diff --git a/lib/ui/client/client_pdf.dart b/lib/ui/client/client_pdf.dart
index 01971eda9..6f1e5c365 100644
--- a/lib/ui/client/client_pdf.dart
+++ b/lib/ui/client/client_pdf.dart
@@ -171,19 +171,6 @@ class _ClientPdfViewState extends State<ClientPdfView> {
       rawResponse: true,
     );
 
-    if (response!.statusCode >= 400) {
-      String errorMessage =
-          '${response.statusCode}: ${response.reasonPhrase}\n\n';
-
-      try {
-        errorMessage += jsonDecode(response.body)['message'];
-      } catch (error) {
-        errorMessage += response.body;
-      }
-
-      throw errorMessage;
-    }
-
     return response;
   }
 
diff --git a/lib/ui/invoice/invoice_pdf.dart b/lib/ui/invoice/invoice_pdf.dart
index 19b30188f..ff0b15d3f 100644
--- a/lib/ui/invoice/invoice_pdf.dart
+++ b/lib/ui/invoice/invoice_pdf.dart
@@ -351,18 +351,5 @@ Future<Response?> _loadPDF(
     response = await WebClient().get(url, '', rawResponse: true);
   }
 
-  if (response!.statusCode >= 400) {
-    String errorMessage =
-        '${response.statusCode}: ${response.reasonPhrase}\n\n';
-
-    try {
-      errorMessage += jsonDecode(response.body)['message'];
-    } catch (error) {
-      errorMessage += response.body;
-    }
-
-    throw errorMessage;
-  }
-
   return response;
 }
diff --git a/lib/utils/designs.dart b/lib/utils/designs.dart
index d1b81d6c0..e3a51c9b9 100644
--- a/lib/utils/designs.dart
+++ b/lib/utils/designs.dart
@@ -48,13 +48,7 @@ void loadDesign({
   webClient
       .post(url, credentials.token, data: json.encode(data), rawResponse: true)
       .then((dynamic response) {
-    if ((response as Response).statusCode >= 400) {
-      showErrorDialog(
-          message: '${response.statusCode}: ${response.reasonPhrase}');
-      onComplete(null);
-    } else {
-      onComplete(response);
-    }
+    onComplete(response);
   }).catchError((dynamic error) {
     showErrorDialog(message: '$error');
     onComplete(null);