From acc372f7a87ac416e68e84b49cf28dfa54f69fd5 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Mon, 28 Dec 2020 17:17:25 +0200 Subject: [PATCH] Make number column in lists a bit narrower --- lib/constants.dart | 1 + lib/ui/client/client_list_item.dart | 2 +- lib/ui/credit/credit_list_item.dart | 7 ++----- lib/ui/expense/expense_list_item.dart | 2 +- lib/ui/invoice/invoice_list_item.dart | 7 ++----- lib/ui/payment/payment_list_item.dart | 6 ++---- lib/ui/product/product_list_item.dart | 2 +- lib/ui/project/project_list_item.dart | 2 +- lib/ui/quote/quote_list_item.dart | 7 ++----- lib/ui/recurring_invoice/recurring_invoice_list_item.dart | 7 ++----- lib/ui/task/task_list_item.dart | 2 +- lib/ui/vendor/vendor_list_item.dart | 2 +- 12 files changed, 17 insertions(+), 30 deletions(-) diff --git a/lib/constants.dart b/lib/constants.dart index 02d52bb45..4bc2e9d9f 100644 --- a/lib/constants.dart +++ b/lib/constants.dart @@ -88,6 +88,7 @@ const double kTableColumnGap = 20; const double kTopBottomBarHeight = 50; const double kDialogWidth = 400; const double kDashboardPanelHeight = 525; // TODO remove this +const double kListNumberWidth = 100; const double kTabletLayoutWidth = 1100; const double kTabletDialogPadding = 250; diff --git a/lib/ui/client/client_list_item.dart b/lib/ui/client/client_list_item.dart index 0d88d9055..9a6bd3fa4 100644 --- a/lib/ui/client/client_list_item.dart +++ b/lib/ui/client/client_list_item.dart @@ -99,6 +99,7 @@ class ClientListItem extends StatelessWidget { ), ), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -110,7 +111,6 @@ class ClientListItem extends StatelessWidget { if (!client.isActive) EntityStateLabel(client) ], ), - width: 120, ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/credit/credit_list_item.dart b/lib/ui/credit/credit_list_item.dart index a38b50216..115af077e 100644 --- a/lib/ui/credit/credit_list_item.dart +++ b/lib/ui/credit/credit_list_item.dart @@ -105,7 +105,8 @@ class CreditListItem extends StatelessWidget { handleEntityAction( context, credit, action), )), - ConstrainedBox( + SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -119,10 +120,6 @@ class CreditListItem extends StatelessWidget { if (!credit.isActive) EntityStateLabel(credit) ], ), - constraints: BoxConstraints( - minWidth: 80, - maxWidth: 80, - ), ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/expense/expense_list_item.dart b/lib/ui/expense/expense_list_item.dart index 26819df38..19c28a6e1 100644 --- a/lib/ui/expense/expense_list_item.dart +++ b/lib/ui/expense/expense_list_item.dart @@ -132,6 +132,7 @@ class ExpenseListItem extends StatelessWidget { ), ), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -143,7 +144,6 @@ class ExpenseListItem extends StatelessWidget { if (!expense.isActive) EntityStateLabel(expense) ], ), - width: 120, ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/invoice/invoice_list_item.dart b/lib/ui/invoice/invoice_list_item.dart index 43acb40ad..6332634bc 100644 --- a/lib/ui/invoice/invoice_list_item.dart +++ b/lib/ui/invoice/invoice_list_item.dart @@ -110,7 +110,8 @@ class InvoiceListItem extends StatelessWidget { handleEntityAction( context, invoice, action), )), - ConstrainedBox( + SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -124,10 +125,6 @@ class InvoiceListItem extends StatelessWidget { if (!invoice.isActive) EntityStateLabel(invoice) ], ), - constraints: BoxConstraints( - minWidth: 80, - maxWidth: 80, - ), ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/payment/payment_list_item.dart b/lib/ui/payment/payment_list_item.dart index abdac5a8a..0ea5a6d25 100644 --- a/lib/ui/payment/payment_list_item.dart +++ b/lib/ui/payment/payment_list_item.dart @@ -105,7 +105,8 @@ class PaymentListItem extends StatelessWidget { handleEntityAction( context, payment, action), )), - ConstrainedBox( + SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -117,9 +118,6 @@ class PaymentListItem extends StatelessWidget { if (!payment.isActive) EntityStateLabel(payment) ], ), - constraints: BoxConstraints( - minWidth: 80, - ), ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/product/product_list_item.dart b/lib/ui/product/product_list_item.dart index f0dcbf914..0c533dc94 100644 --- a/lib/ui/product/product_list_item.dart +++ b/lib/ui/product/product_list_item.dart @@ -102,6 +102,7 @@ class ProductListItem extends StatelessWidget { context, product, action), )), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -114,7 +115,6 @@ class ProductListItem extends StatelessWidget { if (!product.isActive) EntityStateLabel(product) ], ), - width: 120, ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/project/project_list_item.dart b/lib/ui/project/project_list_item.dart index 7361b6056..08c25c023 100644 --- a/lib/ui/project/project_list_item.dart +++ b/lib/ui/project/project_list_item.dart @@ -104,6 +104,7 @@ class ProjectListItem extends StatelessWidget { ), ), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -115,7 +116,6 @@ class ProjectListItem extends StatelessWidget { if (!project.isActive) EntityStateLabel(project) ], ), - width: 120, ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/quote/quote_list_item.dart b/lib/ui/quote/quote_list_item.dart index 64e617afc..86ec1c8f4 100644 --- a/lib/ui/quote/quote_list_item.dart +++ b/lib/ui/quote/quote_list_item.dart @@ -102,7 +102,8 @@ class QuoteListItem extends StatelessWidget { handleEntityAction( context, quote, action), )), - ConstrainedBox( + SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -116,10 +117,6 @@ class QuoteListItem extends StatelessWidget { if (!quote.isActive) EntityStateLabel(quote) ], ), - constraints: BoxConstraints( - minWidth: 80, - maxWidth: 80, - ), ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/recurring_invoice/recurring_invoice_list_item.dart b/lib/ui/recurring_invoice/recurring_invoice_list_item.dart index 748bc08f9..592b1cc27 100644 --- a/lib/ui/recurring_invoice/recurring_invoice_list_item.dart +++ b/lib/ui/recurring_invoice/recurring_invoice_list_item.dart @@ -107,7 +107,8 @@ class RecurringInvoiceListItem extends StatelessWidget { handleEntityAction( context, invoice, action), )), - ConstrainedBox( + SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -121,10 +122,6 @@ class RecurringInvoiceListItem extends StatelessWidget { if (!invoice.isActive) EntityStateLabel(invoice) ], ), - constraints: BoxConstraints( - minWidth: 80, - maxWidth: 80, - ), ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/task/task_list_item.dart b/lib/ui/task/task_list_item.dart index bcad2a239..f29793132 100644 --- a/lib/ui/task/task_list_item.dart +++ b/lib/ui/task/task_list_item.dart @@ -133,6 +133,7 @@ class TaskListItem extends StatelessWidget { ), ), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -144,7 +145,6 @@ class TaskListItem extends StatelessWidget { if (!task.isActive) EntityStateLabel(task) ], ), - width: 120, ), SizedBox(width: 10), Expanded( diff --git a/lib/ui/vendor/vendor_list_item.dart b/lib/ui/vendor/vendor_list_item.dart index 9bf7578f3..c5da30964 100644 --- a/lib/ui/vendor/vendor_list_item.dart +++ b/lib/ui/vendor/vendor_list_item.dart @@ -100,6 +100,7 @@ class VendorListItem extends StatelessWidget { ), ), SizedBox( + width: kListNumberWidth, child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ @@ -111,7 +112,6 @@ class VendorListItem extends StatelessWidget { if (!vendor.isActive) EntityStateLabel(vendor) ], ), - width: 120, ), SizedBox(width: 10), Expanded(