From 00d9c616512d51d2910d65fd384769476c7d68a2 Mon Sep 17 00:00:00 2001 From: Dave Shoreman Date: Mon, 13 Jan 2025 16:23:18 +0000 Subject: [PATCH] Fix rebase/refactor typos Fixes the bank buttons which weren't getting their handlers registered thanks to the `null` making it go down the wrong path, and makes sure to use the institution id from the object passed in, not the institution_id variable from the global scope which is only defined for renewals. Resolves #10501 --- resources/views/bank/nordigen/handler.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/bank/nordigen/handler.blade.php b/resources/views/bank/nordigen/handler.blade.php index 377ef728c8..e1888b9241 100644 --- a/resources/views/bank/nordigen/handler.blade.php +++ b/resources/views/bank/nordigen/handler.blade.php @@ -59,7 +59,7 @@ clone.classList.replace('ob-list-institution', 'ob-history-option'); clone.querySelector('.ob-span-text').innerText = `${max_history} days`; - url.searchParams.set('institution_id', institutionId); + url.searchParams.set('institution_id', institution.id); // When we come from the renew button we need to replace the country flag if (skippedSelect) { @@ -101,7 +101,7 @@ new institutionSelector(institutions, 'institution-modal-content', config); - if (null !== institutionId && !failedReason) { + if ('' !== institutionId && !failedReason) { createSelectionUI( document.querySelector('.ob-institution'), institutions.find(i => i.id == institutionId),