Sultan
/
invoiceninja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Additional validation rules on bulk requests

This commit is contained in:
David Bomba 2025-08-16 08:33:24 +10:00
parent dceee1adbc
commit b151f46211
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/Http/Requests/Invoice/BulkInvoiceRequest.php
View File

@ -45,9 +45,10 @@ class BulkInvoiceRequest extends Request
throw new DuplicatePaymentException('Action still processing, please wait. ', 429);
}
$delay = $this->input('action', 'delete') == 'delete' ? (min(count($this->input('ids', 2)), 3)) : 1;
\Illuminate\Support\Facades\Cache::put(($this->ip()."|".$this->input('action', 0)."|".$user->company()->company_key), true, $delay);
if($this->input('ids', false)){
$delay = $this->input('action', 'delete') == 'delete' ? (min(count($this->input('ids', 2)), 3)) : 1;
\Illuminate\Support\Facades\Cache::put(($this->ip()."|".$this->input('action', 0)."|".$user->company()->company_key), true, $delay);
}
}
}

16
tests/Unit/InvoiceTest.php
View File

@ -52,6 +52,22 @@ class InvoiceTest extends TestCase
}
public function testBulkInvoiceValidationRequestFailsWithMissingIds()
{
$data = [
'action' => 'archive',
];
$response = $this->withHeaders([
'X-API-SECRET' => config('ninja.api_secret'),
'X-API-TOKEN' => $this->token,
])->postJson('/api/v1/invoices/bulk', $data);
$response->assertStatus(422);
$response->assertJsonValidationErrors('ids');
}
public function testInvoiceItemRoundingWithDiscountIsPercent()
{