From b7b5b85b898c92bd03467a9621f4fc8d6071381d Mon Sep 17 00:00:00 2001 From: David Bomba Date: Tue, 6 May 2025 15:26:56 +1000 Subject: [PATCH] Fixes for tests --- app/PaymentDrivers/Authorize/AuthorizeCreditCard.php | 6 ++++-- app/PaymentDrivers/Authorize/RefundTransaction.php | 8 -------- tests/Feature/MultiPaymentDeleteTest.php | 3 +++ 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php b/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php index ac2e44bd4f..59e1e872fe 100644 --- a/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php +++ b/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php @@ -225,8 +225,10 @@ class AuthorizeCreditCard implements LivewireMethodInterface $payment_record['gateway_type_id'] = GatewayType::CREDIT_CARD; $payment_record['transaction_reference'] = $response->getTransId(); - $fds_review = $response->getResponseCode(); - + if(in_array($response->getResponseCode(), [ "4", "253" ])) { + $payment_record['private_notes'] = 'InFDSReview'; + } + $payment = $this->authorize->createPayment($payment_record); return $payment; diff --git a/app/PaymentDrivers/Authorize/RefundTransaction.php b/app/PaymentDrivers/Authorize/RefundTransaction.php index 2503900b13..c65e7f3b6d 100644 --- a/app/PaymentDrivers/Authorize/RefundTransaction.php +++ b/app/PaymentDrivers/Authorize/RefundTransaction.php @@ -61,14 +61,6 @@ class RefundTransaction // Set the transaction's refId $refId = 'ref'.time(); - // $paymentProfile = new PaymentProfileType(); - // $paymentProfile->setPaymentProfileId($transaction_details->getTransaction()->getProfile()->getCustomerPaymentProfileId()); - - // // // set customer profile - // $customerProfile = new CustomerProfilePaymentType(); - // $customerProfile->setCustomerProfileId($transaction_details->getTransaction()->getProfile()->getCustomerProfileId()); - // $customerProfile->setPaymentProfile($paymentProfile); - $creditCard = new CreditCardType(); $creditCard->setCardNumber($creditCardNumber); $creditCard->setExpirationDate($creditCardExpiry); diff --git a/tests/Feature/MultiPaymentDeleteTest.php b/tests/Feature/MultiPaymentDeleteTest.php index e2949e5f54..222811d8a6 100644 --- a/tests/Feature/MultiPaymentDeleteTest.php +++ b/tests/Feature/MultiPaymentDeleteTest.php @@ -157,6 +157,8 @@ class MultiPaymentDeleteTest extends TestCase $this->assertEquals(162, $invoice->client->fresh()->balance); $this->assertEquals(163, $invoice->client->fresh()->paid_to_date); + sleep(1); + $data = [ 'amount' => 162.0, 'client_id' => $this->encodePrimaryKey($client->id), @@ -289,6 +291,7 @@ class MultiPaymentDeleteTest extends TestCase ], 'date' => '2019/12/12', ]; +sleep(1); $response = $this->withHeaders([ 'X-API-SECRET' => config('ninja.api_secret'),