Sultan
/
invoiceninja
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fine-tune transaction history options 

Replaces 360 days with 365, skips the last auto-generated option to
avoid getting e.g. 720 and 730 as options when it's close to max, and
gradually increases the accumulator so options aren't so overwhelming.

Since the loop will no longer generate the final option (0 < 15), this
commit also removes the `% 30` check so the real max is always used.
This commit is contained in:
Dave Shoreman 2024-12-20 04:57:48 +00:00
parent 74344d1b88
commit c9a702fa3e
No known key found for this signature in database
GPG Key ID: C920D1D63709F443
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
resources/views/bank/nordigen/handler.blade.php
View File

@ -71,25 +71,30 @@
_changeHeading('Select your transaction history'); _changeHeading('Select your transaction history');
clone.classList.replace('ob-list-institution', 'ob-history-option'); clone.classList.replace('ob-list-institution', 'ob-history-option');
clone.querySelector('span').innerText = `${max_history} days`;
url.searchParams.set('institution_id', institutionId); url.searchParams.set('institution_id', institutionId);
for (let i = 30; i <= max_history; i += 30) { for (let i = 30, next = 30; i <= max_history; i += next) {
// If we're close to max, just use the real value
if (max_history - i < 15) {
continue;
}
const option = clone.cloneNode(true); const option = clone.cloneNode(true);
url.searchParams.set('tx_days', i); url.searchParams.set('tx_days', i == 360 ? 365 : i);
option.querySelector('span').innerText = `${i} days`; option.querySelector('span').innerText = `${i == 360 ? 365 : i} days`;
option.querySelector('a').href = url.href; option.querySelector('a').href = url.href;
container.append(option); container.append(option);
// 1, 2, 3, 4, 6, 9, 12, 14, 18, 24 months--as of 20/12/24, no bank exceeds 730 days of history
next = i >= 500 ? 180 : i >= 400 ? 120 : i >= 360 ? 60 : i >= 180 ? 90 : i >= 120 ? 60 : 30;
} }
if (max_history % 30 !== 0) { url.searchParams.set('tx_days', max_history);
url.searchParams.set('tx_days', max_history); clone.querySelector('a').href = url.href;
container.append(clone);
clone.querySelector('span').innerText = `${max_history} days`;
clone.querySelector('a').href = url.href;
container.append(clone);
}
}); });
}); });
}); });